RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation [v3]

Valerie Peng valeriep at openjdk.java.net
Fri May 14 19:46:20 UTC 2021


On Fri, 14 May 2021 00:15:09 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   PKCS11Exception class refactoring - use enum instead of HashMap
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Exception.java line 212:
> 
>> 210:         long value() {
>> 211:             return value;
>> 212:         }
> 
> I guess it is safe to use the 'value' variable directly for enum.  The value() method may be not necessary.  Just a personal preference, ignore it if you like the current way.

Sure, I like it too. Will update.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3709


More information about the security-dev mailing list