RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation [v3]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Fri May 14 21:17:59 UTC 2021


On Fri, 14 May 2021 19:42:26 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Exception.java line 212:
>> 
>>> 210:         long value() {
>>> 211:             return value;
>>> 212:         }
>> 
>> I guess it is safe to use the 'value' variable directly for enum.  The value() method may be not necessary.  Just a personal preference, ignore it if you like the current way.
>
> Sure, I like it too. Will update.

Thank you.  I have no more comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3709



More information about the security-dev mailing list