RFR: 8255557: Decouple GCM from CipherCore [v4]
Anthony Scarpino
ascarpino at openjdk.java.net
Fri May 21 04:18:41 UTC 2021
On Wed, 19 May 2021 21:18:15 GMT, Valerie Peng <valeriep at openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 628:
>
>> 626: }
>> 627:
>> 628: int mergeBlock(byte[] buffer, int bufOfs, byte[] in, int inOfs,
>
> Can be made 'static'? No javadoc for this one, maybe move the javadoc for the other one up and use "Methods" in the javadoc to cover both?
I just copied it and made a slight change to explain the difference
-------------
PR: https://git.openjdk.java.net/jdk/pull/4072
More information about the security-dev
mailing list