RFR: 8255557: Decouple GCM from CipherCore [v4]

[Anthony Scarpino]

On Fri, 21 May 2021 01:57:08 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 1503:
> 
>> 1501:                 tag.put(ct);
>> 1502:                 tag.flip();
>> 1503:                 // Limit is how much of the ibuffer has been chopped off.
> 
> The comment seems incorrect? Limit is not how much the ibuffer has been chopped off, but rather what has not been chopped off, no?

I think it's which direction you are looking at it from, when I wrote this I was thinking how much of the ibuffer was chopped off into tag.. i can reword that because its ambiguous.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072