RFR: 8255557: Decouple GCM from CipherCore [v3]

Anthony Scarpino ascarpino at openjdk.java.net
Mon May 24 16:40:19 UTC 2021


On Tue, 18 May 2021 17:24:13 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GHASH.java line 189:
> 
>> 187:             ct.position(ct.position());
>> 188:             return processed;
>> 189:         } else if (!ct.isReadOnly()) {
> 
> Maybe you meant "ct.hasArray()" instead of "!ct.isReadOnly()"?

hasArray() checks both isReadonly() and isDirect().  Since I already did isDirect() in the previous if, I just need to check readonly here

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072



More information about the security-dev mailing list