RFR: 8273826: Correct Manifest file name and NPE checks

Weijun Wang weijun at openjdk.java.net
Wed Oct 6 18:03:11 UTC 2021


On Wed, 6 Oct 2021 16:58:51 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

> Use correct manifest file name in the Manifest verifier checks. 
> Also - extra null check
> 
> The test doesn't reproduce the exact issue reported but should prevent future regressions in this area.

Marked as reviewed by weijun (Reviewer).

src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java line 66:

> 64: 
> 65:     private String name = null;
> 66:     private String manifestFileName;

Make this final and add a comment that it will never be null.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5841



More information about the security-dev mailing list