RFR: 8273826: Correct Manifest file name and NPE checks [v2]
Sean Coffey
coffeys at openjdk.java.net
Thu Oct 7 14:24:10 UTC 2021
On Wed, 6 Oct 2021 17:54:15 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Make variables final
>
> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java line 66:
>
>> 64:
>> 65: private String name = null;
>> 66: private String manifestFileName;
>
> Make this final and add a comment that it will never be null.
Thanks for the review - Made final and added comment. Also decided to make the "Manifest man" variable final here also while here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5841
More information about the security-dev
mailing list