RFR: 8273826: Correct Manifest file name and NPE checks [v2]

Weijun Wang weijun at openjdk.java.net
Thu Oct 7 15:02:11 UTC 2021


On Thu, 7 Oct 2021 14:21:27 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java line 66:
>> 
>>> 64: 
>>> 65:     private String name = null;
>>> 66:     private String manifestFileName;
>> 
>> Make this final and add a comment that it will never be null.
>
> Thanks for the review - Made final and added comment. Also decided to make the "Manifest man" variable final here also while here.

Great, the more final there are, the less I need to look back and forth while reading the code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5841



More information about the security-dev mailing list