RFR: 8285431: Assertion in NativeGSSContext constructor

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Fri Apr 22 06:33:00 UTC 2022


Hi,

May I have the simple update reviewed.

In the NativeGSSContext constructor for imported context, the assert is use on the object field, instead of the input parameters. As in a constructor, `'this'` object does not exist yet, this looks like an obvious issue.  The fix is straightforward as well. 


    NativeGSSContext(long pCtxt, GSSLibStub stub) throws GSSException {
-       assert(pContext != 0);
+       assert(pCtxt != 0);
        pContext = pCtxt;
        ...

-------------

Commit messages:
 - 8285431: Assertion in NativeGSSContext constructor

Changes: https://git.openjdk.java.net/jdk/pull/8355/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8355&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8285431
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8355.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8355/head:pull/8355

PR: https://git.openjdk.java.net/jdk/pull/8355



More information about the security-dev mailing list