RFR: 8285431: Assertion in NativeGSSContext constructor

Daniel Jeliński djelinski at openjdk.java.net
Fri Apr 22 13:18:21 UTC 2022


On Fri, 22 Apr 2022 06:26:01 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

> Hi,
> 
> May I have the simple update reviewed.
> 
> In the NativeGSSContext constructor for imported context, the assert is use on the object field, instead of the input parameters. As in a constructor, `'this'` object does not exist yet, this looks like an obvious issue.  The fix is straightforward as well. 
> 
> 
>     NativeGSSContext(long pCtxt, GSSLibStub stub) throws GSSException {
> -       assert(pContext != 0);
> +       assert(pCtxt != 0);
>         pContext = pCtxt;
>         ...

LGTM

-------------

Marked as reviewed by djelinski (Committer).

PR: https://git.openjdk.java.net/jdk/pull/8355



More information about the security-dev mailing list