RFR: 8285683: Missing @ since 11 in java.security.spec.MGF1ParameterSpec fields

Sean Mullan mullan at openjdk.java.net
Wed Apr 27 13:11:43 UTC 2022


On Tue, 26 Apr 2022 22:55:29 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

> Two new constant fields `MGF1ParameterSpec.SHA512_224` and `MGF1ParameterSpec.SHA512_256` didn't have `@since 11` tag added as part of [JDK-8146293](https://bugs.openjdk.java.net/browse/JDK-8146293). 
> 
> This bug addresses this issue.

src/java.base/share/classes/java/security/spec/MGF1ParameterSpec.java line 98:

> 96: 
> 97:     /**
> 98:      * The MGF1ParameterSpec which uses SHA-512/224 message digest

Feel free to cover this as a separate issue, but I think these constant descriptions should end with a period. Also, I would say "... uses _a_ SHA-512/224 message digest." (change in italics). There is also some inconsistency in the constants, some put the digest algorithm in double-quotes while others don't - it would be good to be consistent.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8411



More information about the security-dev mailing list