RFR: 8285683: Missing @ since 11 in java.security.spec.MGF1ParameterSpec fields [v3]

Bradford Wetmore wetmore at openjdk.java.net
Wed Apr 27 17:12:30 UTC 2022


On Wed, 27 Apr 2022 13:08:03 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Missed one minor codereview suggestion.
>
> src/java.base/share/classes/java/security/spec/MGF1ParameterSpec.java line 98:
> 
>> 96: 
>> 97:     /**
>> 98:      * The MGF1ParameterSpec which uses SHA-512/224 message digest
> 
> Feel free to cover this as a separate issue, but I think these constant descriptions should end with a period. Also, I would say "... uses _a_ SHA-512/224 message digest." (change in italics). There is also some inconsistency in the constants, some put the digest algorithm in double-quotes while others don't - it would be good to be consistent.

Updated for consistency.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8411



More information about the security-dev mailing list