RFR: 6205692: (spec) javax.crypto.MacSpi.engineUpdate(ByteBuffer input): NPE should be specified [v2]

Kevin Driver kdriver at openjdk.org
Fri Aug 12 19:20:52 UTC 2022


On Fri, 12 Aug 2022 18:47:21 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment
>
> src/java.base/share/classes/javax/crypto/MacSpi.java line 105:
> 
>> 103:      * @param input the ByteBuffer
>> 104:      *
>> 105:      * @exception NullPointerException if {@code input} is null
> 
> nit: I recall @throws is preferred.
> 
> How about the update(...) methods in javax.crypto.Mac class? Perhaps the NPE there should be documented as well?

@valeriepeng see https://github.com/openjdk/jdk/pull/9859/commits/0bc0394e7a72f40b1f8f7cd4056b5906d4b89eda for the proposed change.

Let me know what you think about consistency within the files wrt `@throws` vs `@exception`.

-------------

PR: https://git.openjdk.org/jdk/pull/9859



More information about the security-dev mailing list