RFR: 6205692: (spec) javax.crypto.MacSpi.engineUpdate(ByteBuffer input): NPE should be specified [v2]

[Valerie Peng]

On Fri, 12 Aug 2022 19:14:34 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/MacSpi.java line 105:
>> 
>>> 103:      * @param input the ByteBuffer
>>> 104:      *
>>> 105:      * @exception NullPointerException if {@code input} is null
>> 
>> nit: I recall @throws is preferred.
>> 
>> How about the update(...) methods in javax.crypto.Mac class? Perhaps the NPE there should be documented as well?
>
> @valeriepeng see https://github.com/openjdk/jdk/pull/9859/commits/0bc0394e7a72f40b1f8f7cd4056b5906d4b89eda for the proposed change.
> 
> Let me know what you think about consistency within the files wrt `@throws` vs `@exception`.

For this particular case, I would go for @throws. Moving toward the newer notation seems better.

-------------

PR: https://git.openjdk.org/jdk/pull/9859