RFR: JDK-8291509 Minor cleanup could be done in sun.security [v3]

Mark Powers mpowers at openjdk.org
Tue Aug 30 20:13:40 UTC 2022


On Tue, 30 Aug 2022 19:36:55 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   white space
>
> src/java.base/share/classes/sun/security/pkcs/SigningCertificateInfo.java line 133:
> 
>> 131:     private final byte[] certHash;
>> 132:     private GeneralNames issuer;
>> 133:     private SerialNumber serialNumber;
> 
> You could also mark these as `final` and add an `else` block to the ctor which sets them to `null`.

Fixed as suggested.

-------------

PR: https://git.openjdk.org/jdk/pull/9972


More information about the security-dev mailing list