RFR: JDK-8291509 Minor cleanup could be done in sun.security [v3]

Mark Powers mpowers at openjdk.org
Tue Aug 30 20:20:14 UTC 2022


On Tue, 30 Aug 2022 19:52:03 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   white space
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 2319:
> 
>> 2317:                         } else {
>> 2318:                             // Different keyId. Not a fallback.
>> 2319:                             continue;
> 
> Personally I prefer seeing "continue" here - it makes it clear that none of the remaining code in this loop is relevant.

Agreed. Adding it back.

-------------

PR: https://git.openjdk.org/jdk/pull/9972



More information about the security-dev mailing list