RFR: JDK-8291509 Minor cleanup could be done in sun.security [v3]

Wed Aug 31 22:46:12 UTC 2022

On Wed, 31 Aug 2022 22:30:57 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Ah, I see. The key for an attr might not be the id.
>
> In fact, I am not sure if this method works now. `PKCS10Attribute` has not overridden `equals`. Is this method ever used? I see it used in `PKCS10` but the encoding is used for comparison there. And, who would want to compare `PKCS10` objects?

The tests that we have all pass. I think I'll intentionally break `equals` and see if the tests still pass. From my experience with PKCS#11, there is no reason to check that attribute arrays are equal.

-------------

PR: https://git.openjdk.org/jdk/pull/9972