RFR: JDK-8291509 Minor cleanup could be done in sun.security [v3]

Mark Powers mpowers at openjdk.org
Wed Aug 31 22:57:13 UTC 2022


On Wed, 31 Aug 2022 22:43:58 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> In fact, I am not sure if this method works now. `PKCS10Attribute` has not overridden `equals`. Is this method ever used? I see it used in `PKCS10` but the encoding is used for comparison there. And, who would want to compare `PKCS10` objects?
>
> The tests that we have all pass. I think I'll intentionally break `equals` and see if the tests still pass. From my experience with PKCS#11, there is no reason to check that attribute arrays are equal.

I broke `equals` to always return false, and tests all passed.

-------------

PR: https://git.openjdk.org/jdk/pull/9972



More information about the security-dev mailing list