RFR: 8282316: Operation before String case conversion [v2]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Wed Feb 23 23:41:36 UTC 2022


> In the SignatureUtil implementation, the checkName() requires case-insensitive input for "OID".  However, the method is called before the case conversion, for example: 
> 
>             sigName = checkName(sigName).toUpperCase(Locale.ENGLISH); 
> 
> This update also clean up redundant calls to the checkName() method.

Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:

  udpate return state as well

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7598/files
  - new: https://git.openjdk.java.net/jdk/pull/7598/files/e90b7305..4faf3da7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7598&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7598&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7598.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7598/head:pull/7598

PR: https://git.openjdk.java.net/jdk/pull/7598



More information about the security-dev mailing list