RFR: 8282316: Operation before String case conversion [v2]

Weijun Wang weijun at openjdk.java.net
Wed Feb 23 23:57:04 UTC 2022


On Wed, 23 Feb 2022 23:41:36 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> In the SignatureUtil implementation, the checkName() requires case-insensitive input for "OID".  However, the method is called before the case conversion, for example: 
>> 
>>             sigName = checkName(sigName).toUpperCase(Locale.ENGLISH); 
>> 
>> This update also clean up redundant calls to the checkName() method.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   udpate return state as well

src/java.base/share/classes/sun/security/util/SignatureUtil.java line 51:

> 49:     /**
> 50:      * Convert OID.1.2.3.4 or 1.2.3.4 to its matching stdName, and literal
> 51:      * name to upper case.

It sounds like you only convert literal name to upper case and return stdName for OIDs.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7598



More information about the security-dev mailing list