RFR: JDK-8285263 Minor cleanup could be done in java.security [v5]

Mark Powers duke at openjdk.java.net
Wed Jun 8 22:21:37 UTC 2022


On Wed, 8 Jun 2022 15:46:28 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - Merge
>>  - fourth iteration
>>  - Merge
>>  - Merge
>>  - third iteration
>>  - Merge
>>  - Merge
>>  - second iteration
>>  - Merge
>>  - Merge
>>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/4d6fb515...44140a01
>
> src/java.base/share/classes/java/security/MessageDigest.java line 306:
> 
>> 304:         } else {
>> 305:             return Delegate.of((MessageDigestSpi)objs[0], algorithm,
>> 306:             (Provider)objs[1]);
> 
> Indent this line.

done

> src/java.base/share/classes/java/security/ProtectionDomain.java line 474:
> 
>> 472:                     return true;
>> 473:                 } catch (SecurityException se) {
>> 474:                     // fall through and return false
> 
> How about we just `return false` here and then there is no need for the `return false` at the end?

done

-------------

PR: https://git.openjdk.java.net/jdk/pull/8319



More information about the security-dev mailing list