RFR: JDK-8285263 Minor cleanup could be done in java.security [v5]

Mark Powers duke at openjdk.java.net
Wed Jun 8 22:25:40 UTC 2022


On Wed, 8 Jun 2022 15:50:38 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - Merge
>>  - fourth iteration
>>  - Merge
>>  - Merge
>>  - third iteration
>>  - Merge
>>  - Merge
>>  - second iteration
>>  - Merge
>>  - Merge
>>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/4d6fb515...44140a01
>
> src/java.base/share/classes/java/security/ProtectionDomain.java line 492:
> 
>> 490:                 Policy p = Policy.getPolicyNoCheck();
>> 491:                 return p.getPermissions(ProtectionDomain.this);
>> 492:             });
> 
> First, indent these lines. (or maybe my GitHub view has not reveals the indentation?).
> 
> Second, inline `p` then there is no need to `return`. Simply `() -> P.g.g(P)`.

I made your suggested change. My viewer shows the indented lines. Go figure.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8319



More information about the security-dev mailing list