RFR: JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes [v2]

Valerie Peng valeriep at openjdk.org
Tue Jun 28 20:24:44 UTC 2022


On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers <duke at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Valerie fix

src/java.base/share/classes/javax/crypto/AEADBadTagException.java line 41:

> 39: 
> 40:     /**
> 41:      * Constructs an <code>AEADBadTagException</code> with no detail message.

Why not using the {@code } as in other files?

src/java.base/share/classes/javax/crypto/AEADBadTagException.java line 48:

> 46: 
> 47:     /**
> 48:      * Constructs an <code>AEADBadTagException</code> with the specified

Same as above, use {@code }?

src/java.base/share/classes/javax/crypto/BadPaddingException.java line 44:

> 42: 
> 43:     /**
> 44:      * Constructs a <code>BadPaddingException</code> with no detail

Use `{@code }`?

src/java.base/share/classes/javax/crypto/BadPaddingException.java line 53:

> 51: 
> 52:     /**
> 53:      * Constructs a <code>BadPaddingException</code> with the specified

Use `{@code }`?

src/java.base/share/classes/javax/crypto/Cipher.java line 184:

> 182: 
> 183:     /**
> 184:      * Constant used to initialize {@code Cipher} to encryption mode.

If it's lower case, we normally just leave it? Not sure what is the criteria for changing this.

-------------

PR: https://git.openjdk.org/jdk/pull/9282



More information about the security-dev mailing list