RFR: JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes [v2]

Valerie Peng valeriep at openjdk.org
Tue Jun 28 20:37:39 UTC 2022


On Tue, 28 Jun 2022 20:21:34 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Valerie fix
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 184:
> 
>> 182: 
>> 183:     /**
>> 184:      * Constant used to initialize {@code Cipher} to encryption mode.
> 
> If it's lower case, we normally just leave it? Not sure what is the criteria for changing this. Is it because these are public static constants, so you prefer more formatting? But then, some have "object" following the `{@code Cipher}`, and some aren't which looks a bit inconsistent.

Personally, I'd against making this change, i.e. changing all "cipher" occurrences to "{@code Cipher}". Can we just stick to fixing what's broken?

-------------

PR: https://git.openjdk.org/jdk/pull/9282



More information about the security-dev mailing list