RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Tue Mar 8 05:55:06 UTC 2022


On Mon, 7 Mar 2022 20:34:02 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo correction
>
> src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java line 204:
> 
>> 202:             } catch (GeneralSecurityException | java.io.IOException e) {
>> 203:                 throw new SSLHandshakeException(
>> 204:                         "Could not generate ECPublicKey", e);
> 
> Nit:  I think combining these lines would be < 80 chars

The exception name is too long to have in one line.  There are 83 characters in total if combining line 203 and 204.  3 characters exceeding 80 chars per line limit is not easy to tell with eyes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7722



More information about the security-dev mailing list