RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

Roger Riggs rriggs at openjdk.java.net
Tue Mar 8 14:52:02 UTC 2022


On Tue, 8 Mar 2022 05:51:21 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java line 204:
>> 
>>> 202:             } catch (GeneralSecurityException | java.io.IOException e) {
>>> 203:                 throw new SSLHandshakeException(
>>> 204:                         "Could not generate ECPublicKey", e);
>> 
>> Nit:  I think combining these lines would be < 80 chars
>
> The exception name is too long to have in one line.  There are 83 characters in total if combining line 203 and 204.  3 characters exceeding 80 chars per line limit is not easy to tell with eyes.

The 80 character recommendation isn't a hard limit, I favor readability in the 80-100 char range.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7722



More information about the security-dev mailing list