RFR: 8002277: Refactor two PBE classes to simplify maintenance [v2]

Valerie Peng valeriep at openjdk.java.net
Mon May 9 23:40:03 UTC 2022


On Fri, 6 May 2022 22:20:32 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright year for PBES2Core.java
>
> src/java.base/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java line 183:
> 
>> 181:                        "for PBEWithSHA1And" + algo);
>> 182:             }
>> 183:         }
> 
> How about using switch/case or at least put the `if` in same indentation level?

Yes, will use switch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8521



More information about the security-dev mailing list