RFR: 8002277: Refactor two PBE classes to simplify maintenance [v2]

Valerie Peng valeriep at openjdk.java.net
Tue May 10 22:07:45 UTC 2022


On Tue, 10 May 2022 00:09:16 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Oh, the comment about "may be 0" is meant toward the pbeKey.getInterationCount() call... Hmm, I will make it clearer.
>
> I see. Another question, shall we reset `salt` and `iCount` at the beginning? If `params` is null and `key` is not `PBEKey` and there is an existing positive `iCount`, it will not be set to `DEFAULT_COUNT`.

Yeah, I see PKCS12PBECipherCore does that. Will update PBES2Core with it too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8521



More information about the security-dev mailing list