RFR: 8002277: Refactor two PBE classes to simplify maintenance [v4]
Valerie Peng
valeriep at openjdk.java.net
Tue May 10 22:29:44 UTC 2022
> This change refactors the PBES2Core and PKCS12PBECipherCore classes in SunJCE provider as requested in the bug record. Functionality should remain the same with a clearer and simplified code/control flow with less lines of code. This should improve readability and maintenance. I enhanced one existing regression test to test more scenarios. This test would pass before the proposed change and continues to pass with the proposed changes.
Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
Address review feedbacks
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8521/files
- new: https://git.openjdk.java.net/jdk/pull/8521/files/307d2765..0907114b
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8521&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8521&range=02-03
Stats: 63 lines in 2 files changed: 5 ins; 5 del; 53 mod
Patch: https://git.openjdk.java.net/jdk/pull/8521.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8521/head:pull/8521
PR: https://git.openjdk.java.net/jdk/pull/8521
More information about the security-dev
mailing list