RFR: 8002277: Refactor two PBE classes to simplify maintenance [v5]

Valerie Peng valeriep at openjdk.java.net
Wed May 11 22:02:42 UTC 2022


> This change refactors the PBES2Core and PKCS12PBECipherCore classes in SunJCE provider as requested in the bug record. Functionality should remain the same with a clearer and simplified code/control flow with less lines of code.  This should improve readability and maintenance. I enhanced one existing regression test to test more scenarios. This test would pass before the proposed change and continues to pass with the proposed changes.

Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:

  Changed to extend various CipherSpi implementations.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8521/files
  - new: https://git.openjdk.java.net/jdk/pull/8521/files/0907114b..39f626e1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8521&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8521&range=03-04

  Stats: 255 lines in 4 files changed: 63 ins; 145 del; 47 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8521.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8521/head:pull/8521

PR: https://git.openjdk.java.net/jdk/pull/8521



More information about the security-dev mailing list