RFR: JDK-8291509 Minor cleanup could be done in sun.security [v4]

Mark Powers mpowers at openjdk.org
Fri Sep 2 01:04:57 UTC 2022


On Thu, 1 Sep 2022 03:31:32 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments from Sean and Max
>
> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 183:
> 
>> 181:     private List<String> weakWarnings = new ArrayList<>();
>> 182: 
>> 183:     private Set<X509Certificate> trustedCerts = new HashSet<>();
> 
> Put all these `final`s in one group.

If I do that, it will mess up existing groups, e.g. `// Warnings on weak algorithms etc`. I was able to move a few files around, but not many.

-------------

PR: https://git.openjdk.org/jdk/pull/9972



More information about the security-dev mailing list