RFR: JDK-8291509 Minor cleanup could be done in sun.security [v6]

Weijun Wang weijun at openjdk.org
Tue Sep 6 18:01:06 UTC 2022


On Fri, 2 Sep 2022 01:02:26 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 183:
>> 
>>> 181:     private List<String> weakWarnings = new ArrayList<>();
>>> 182: 
>>> 183:     private Set<X509Certificate> trustedCerts = new HashSet<>();
>> 
>> Put all these `final`s in one group.
>
> If I do that, it will mess up existing groups, e.g. `// Warnings on weak algorithms etc`. I was able to move a few files around, but not many.

OK.

-------------

PR: https://git.openjdk.org/jdk/pull/9972



More information about the security-dev mailing list