RFR: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries [v2]

Jiangli Zhou jiangli at openjdk.org
Wed Apr 12 17:18:25 UTC 2023


> Rename 'handleSocketError' to 'sctpHandleSocketError' in libsctp. This resolves the related duplicate symbol failures when both libnio and libsctp are statically linked with the launcher.
> 
> Remove #include "nio_util.h" from SctpChannelImpl.c and SctpNet.c. Looks like that's only needed for handleSocketError() declaration. Declare sctpHandleSocketError() in Sctp.h.
> 
> (Sorry about the earlier RFR/Withdrawn noise.)

Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:

  Make loadSocketExtensionFuncs as a static function.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13438/files
  - new: https://git.openjdk.org/jdk/pull/13438/files/ea9627a4..321fa6d5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13438&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13438&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/13438.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13438/head:pull/13438

PR: https://git.openjdk.org/jdk/pull/13438



More information about the security-dev mailing list