RFR: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries [v2]

Wed Apr 12 17:18:25 UTC 2023

On Wed, 12 Apr 2023 17:13:56 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> Rename 'handleSocketError' to 'sctpHandleSocketError' in libsctp. This resolves the related duplicate symbol failures when both libnio and libsctp are statically linked with the launcher.
>> 
>> Remove #include "nio_util.h" from SctpChannelImpl.c and SctpNet.c. Looks like that's only needed for handleSocketError() declaration. Declare sctpHandleSocketError() in Sctp.h.
>> 
>> (Sorry about the earlier RFR/Withdrawn noise.)
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make loadSocketExtensionFuncs as a static function.

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13438#pullrequestreview-1381756250