RFR: 8297878: KEM: Implementation

[Sean Mullan]

On Fri, 31 Mar 2023 02:25:04 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> The KEM API and DHKEM impl. Note that this PR uses new methods in https://github.com/openjdk/jdk/pull/13250.

src/java.base/share/classes/javax/crypto/KEM.java line 493:

> 491:      * Creates a KEM encapsulator.
> 492:      * <p>
> 493:      * The method is equivalent to {@code newEncapsulator(pk, null, null)}.

s/The/This/

src/java.base/share/classes/javax/crypto/KEM.java line 500:

> 498:      * @throws NullPointerException if {@code pk} is {@code null}
> 499:      * @throws UnsupportedOperationException if this method is not supported
> 500:      *          and a {@code AlgorithmParameterSpec} must be provided

I would say "... because an {@code AlgorithmParameterSpec} must be provided".

src/java.base/share/classes/javax/crypto/KEM.java line 515:

> 513:      * Creates a KEM encapsulator.
> 514:      * <p>
> 515:      * The method is equivalent to {@code newEncapsulator(pk, null, secureRandom)}.

s/The/This/

src/java.base/share/classes/javax/crypto/KEM.java line 518:

> 516:      *
> 517:      * @param pk the receiver's public key, must not be {@code null}
> 518:      * @param secureRandom the source of randomness for encapsulation,

s/,/./

src/java.base/share/classes/javax/crypto/KEM.java line 519:

> 517:      * @param pk the receiver's public key, must not be {@code null}
> 518:      * @param secureRandom the source of randomness for encapsulation,
> 519:      *                     If {@code null}, the implementation should provide

s/should/must/

src/java.base/share/classes/javax/crypto/KEM.java line 556:

> 554:      * @param pk the receiver's public key, must not be {@code null}
> 555:      * @param spec the optional parameter, can be {@code null}
> 556:      * @param secureRandom the source of randomness for encapsulation,

s/,/./

src/java.base/share/classes/javax/crypto/KEM.java line 557:

> 555:      * @param spec the optional parameter, can be {@code null}
> 556:      * @param secureRandom the source of randomness for encapsulation,
> 557:      *                     If {@code null}, the implementation should provide

s/should/must/

src/java.base/share/classes/javax/crypto/KEM.java line 577:

> 575:      * Creates a KEM decapsulator.
> 576:      * <p>
> 577:      * The method is equivalent to {@code newDecapsulator(sk, null)}.

s/The/This/

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165877912
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165882608
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165882987
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165883370
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165883547
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165886660
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165886977
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165884344