RFR: 8297878: KEM: Implementation

Weijun Wang weijun at openjdk.org
Thu Apr 13 18:51:37 UTC 2023


On Thu, 13 Apr 2023 18:21:51 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> The KEM API and DHKEM impl. Note that this PR uses new methods in https://github.com/openjdk/jdk/pull/13250.
>
> src/java.base/share/classes/javax/crypto/KEM.java line 519:
> 
>> 517:      * @param pk the receiver's public key, must not be {@code null}
>> 518:      * @param secureRandom the source of randomness for encapsulation,
>> 519:      *                     If {@code null}, the implementation should provide
> 
> s/should/must/

This spec is not written for the implementor. How about "If {@code} null, a default one from the implementation will be used.".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165908210



More information about the security-dev mailing list