RFR: 8301443: Clean broken comments from Windows code [v2]
Alexey Ivanov
aivanov at openjdk.org
Sat Feb 4 17:25:48 UTC 2023
On Sat, 4 Feb 2023 13:36:54 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> I did think about that too when I first saw it, but the command this is often run from is the Windows CMD, which does not accept `` to escape to the next line. MSYS bash does not have the required environment set up outside of configure time to run `cl` either, but I have not tested with WSL yet. I suppose one could do the complicated setup required to be able to run this from the winenv provided bash, but that seems like a lot of hassle, enough that to me someone trying to compile sspi_bridge.dll by itself wouldn't really bother with the process. On top of that cl.exe will actually interpret the backslash as the literal object file `.o` for some weird reason. I've already pinged the original author of the file @wangweij above to ask for guidance on this as such
>
> I have no objection to the code change. Or maybe you can change it to the windows line extension character `^`.
>
> I was using this command for quick recompiling while writing this code, and it's in a cmd.exe window launched with a start menu item named something like "Visual Studio Developing Environment". I wrote it inside here to remind myself if I need to rework on it.
I used to have Visual Studio compilers available in my Cygwin environment. Now I don't, I just point the `configure` script to the batch file which configures the environment.
If this command is supposed to be run in `cmd.exe`, then `^` makes more sense: one could just copy & paste the command.
-------------
PR: https://git.openjdk.org/jdk/pull/12305
More information about the security-dev
mailing list