RFR: 8301443: Clean broken comments from Windows code [v2]
Julian Waters
jwaters at openjdk.org
Sun Feb 5 15:57:50 UTC 2023
On Sat, 4 Feb 2023 17:23:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> I have no objection to the code change. Or maybe you can change it to the windows line extension character `^`.
>>
>> I was using this command for quick recompiling while writing this code, and it's in a `cmd.exe` window launched with a start menu item named something like "Visual Studio Developing Environment". I wrote it inside here to remind myself if I need to rework on it.
>
> I used to have Visual Studio compilers available in my Cygwin environment. Now I don't, I just point the `configure` script to the batch file which configures the environment.
>
> If this command is supposed to be run in `cmd.exe`, then `^` makes more sense: one could just copy & paste the command.
I've just tried copying and pasting the command with ^ instead of \ and cmd doesn't seem to be correctly reading the compile command either even with ^, is there something I'm missing here?
-------------
PR: https://git.openjdk.org/jdk/pull/12305
More information about the security-dev
mailing list