RFR: 8301443: Clean broken comments from Windows code [v2]

Julian Waters jwaters at openjdk.org
Mon Feb 6 03:37:04 UTC 2023


On Sun, 5 Feb 2023 17:26:29 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> I've just tried copying and pasting the command with ^ instead of \ and cmd doesn't seem to be correctly reading the compile command either even with ^, is there something I'm missing here?
>
> I don't know. I'm quite sure I was using the full command in `cmd.exe` after calling some `vcvars64.bat`. I added the `` character because it's a little long to be recorded here. I don't really care which separator is used. You can remove the `` character. We don't need to spend too much time on this.

Honestly, with all of this confusion around the command line, I think I'd rather just avoid the issue entirely by turning this into a multiline comment so the backslash doesn't cause compiler warnings

-------------

PR: https://git.openjdk.org/jdk/pull/12305



More information about the security-dev mailing list