RFR: 8301443: Clean broken comments from Windows code [v2]
Alexey Ivanov
aivanov at openjdk.org
Tue Feb 7 15:34:20 UTC 2023
On Mon, 6 Feb 2023 03:31:15 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> I don't know. I'm quite sure I was using the full command in `cmd.exe` after calling some `vcvars64.bat`. I added the `` character because it's a little long to be recorded here. I don't really care which separator is used. You can remove the `` character. We don't need to spend too much time on this.
>
> Honestly, with all of this confusion around the command line, I think I'd rather just avoid the issue entirely by turning this into a multiline comment so the backslash doesn't cause compiler warnings
I don't know what the error message you get, but `^` definitely works for me as continuation line marker in `cmd.exe`.
C:\dev\jdk-dev>cl -I %OPENJDK%\src\java.security.jgss\share\native\libj2gss\ sspi.cpp ^
More? -link -dll -out:sspi_bridge.dll
'cl' is not recognized as an internal or external command,
operable program or batch file.
This `More?` prompt identifies the continuation line.
Anyway, we decided to leave it as is but convert to multi-line comment, which is fine with me.
-------------
PR: https://git.openjdk.org/jdk/pull/12305
More information about the security-dev
mailing list