RFR: 8301443: Clean broken comments from Windows code [v5]
Julian Waters
jwaters at openjdk.org
Tue Feb 7 16:00:09 UTC 2023
On Tue, 7 Feb 2023 15:14:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - D3DVertexCacher.cpp
>> - awt_List.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_List.cpp line 183:
>
>> 181: // SetWindowPos(hList, 0, 0, 0, w, h, flags);
>> 182: // }
>> 183: //
>
> Maybe it's time to remove this commented out code? It's been commented out since 2007 when the code moved to Mercurial.
>
> If you decide to remove it, please submit a new issue to communicate the intention clearly.
Perhaps, but I'll leave that to the discretion of the client libs group. Are the new changes fine with you though?
-------------
PR: https://git.openjdk.org/jdk/pull/12305
More information about the security-dev
mailing list