RFR: 8301443: Clean broken comments from Windows code [v5]
Alexey Ivanov
aivanov at openjdk.org
Tue Feb 7 16:14:56 UTC 2023
On Tue, 7 Feb 2023 15:57:35 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_List.cpp line 183:
>>
>>> 181: // SetWindowPos(hList, 0, 0, 0, w, h, flags);
>>> 182: // }
>>> 183: //
>>
>> Maybe it's time to remove this commented out code? It's been commented out since 2007 when the code moved to Mercurial.
>>
>> If you decide to remove it, please submit a new issue to communicate the intention clearly.
>
> Perhaps, but I'll leave that to the discretion of the client libs group. Are the new changes fine with you though?
I'd rather remove the offending commented out code than change its formatting.
Could you submit a bug, please, and assign it to me?
There's a closed test associated with [JDK-4046446](https://bugs.openjdk.org/browse/JDK-4046446), it can be open-sourced. Then it'll be safe to remove the commented out code.
-------------
PR: https://git.openjdk.org/jdk/pull/12305
More information about the security-dev
mailing list