RFR: 8311943: Cleanup usages of toLowerCase() and toUpperCase() in java.base

Alan Bateman alanb at openjdk.org
Wed Jul 12 13:29:11 UTC 2023


On Mon, 3 Jul 2023 20:53:34 GMT, Glavo <duke at openjdk.org> wrote:

> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.

src/java.base/share/classes/java/io/StreamTokenizer.java line 632:

> 630:             sval = String.copyValueOf(buf, 0, i);
> 631:             if (forceLower)
> 632:                 sval = sval.toLowerCase(Locale.ROOT);

I suspect this change to StreamTokenizer needs eyes. I think long standing behavior of the lowerCaseMode(true) has been to use the rules for the default locale so we need to be careful.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14763#discussion_r1261178834


More information about the security-dev mailing list