RFR: 8290005: com/sun/jndi/ldap/LdapCBPropertiesTest.java failling with NullPointerException [v6]

[Xue-Lei Andrew Fan]

On Fri, 14 Jul 2023 20:00:55 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

>> In this PR, I added methods to the TransportContext class to synchronize access to the handshakeContext field. I also updated locations in the code that rely on the handshakeContext field to not be null to use the synchronized methods.
>> 
>> Thanks
>
> Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge branch 'master' into socket-close-null
>  - Removed changes in TransportContext; changed SSLSocketImpl to use conContext.protocolVersion during close operation
>  - Merge branch 'master' into socket-close-null
>  - Merge branch 'master' into socket-close-null
>  - reverted changes in SSLEngineImpl
>  - I missed a method that needed updating
>  - Merge branch 'master' into socket-close-null
>  - made handshake context lock final
>  - using try/finally in terminateHandshakeContext and using local context variable in all places it should be
>  - 8290005: com/sun/jndi/ldap/LdapCBPropertiesTest.java failling with NullPointerException

Looks good to me.  Thank you!

-------------

Marked as reviewed by xuelei (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13742#pullrequestreview-1531045819