RFR: 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors [v3]

[Weijun Wang]

On Tue, 14 Mar 2023 14:24:20 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> Hello all,
>> 
>> This addresses a test bug where the SimpleOCSPServer would reset the connections made by a client CertPathValidator.  I've made some minor changes to how the network data is read and sent from OCSP HTTP GET URLs and on responses, respectively.  This will take the test off the problem list as well.
>> 
>> This has been taken through hundreds of test runs and does not see the failure any longer where there used to be intermittent failures.  Also multiple tier2 runs have been executed with no failures.
>> 
>> - JBS: https://bugs.openjdk.org/browse/JDK-8300939
>
> Jamil Nimeh has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
> 
>  - merge with main
>  - merge with main
>  - 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors
>  - Merge with main
>  - Restore policy Root.java lost during merge
>  - Merge with main
>  - 8300946: Add sun/security/provider/certpath/OCSP/OCSPNoContentLength to ProblemList
>  - Remove dead commented code
>  - Throw exception directly from non 200 HTTP response codes
>  - Moved SimpleOCSPServer to use CountdownLatch for ready state, updated tests
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/55aa1224...b2d25b7e

Looks fine. Just one comment.

test/jdk/java/security/testlibrary/SimpleOCSPServer.java line 340:

> 338:      */
> 339:     private static String dumpHexBytes(byte[] data, int dataLen,
> 340:             int itemsPerLine, String lineDelim, String itemDelim) {

You always call with `dataLen = data.length`. Is it still necessary to add this argument?

-------------

PR: https://git.openjdk.org/jdk/pull/12370