RFR: 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors [v3]

Jamil Nimeh jnimeh at openjdk.org
Tue Mar 14 15:40:39 UTC 2023


On Tue, 14 Mar 2023 15:01:07 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Jamil Nimeh has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - merge with main
>>  - merge with main
>>  - 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors
>>  - Merge with main
>>  - Restore policy Root.java lost during merge
>>  - Merge with main
>>  - 8300946: Add sun/security/provider/certpath/OCSP/OCSPNoContentLength to ProblemList
>>  - Remove dead commented code
>>  - Throw exception directly from non 200 HTTP response codes
>>  - Moved SimpleOCSPServer to use CountdownLatch for ready state, updated tests
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/55aa1224...b2d25b7e
>
> test/jdk/java/security/testlibrary/SimpleOCSPServer.java line 340:
> 
>> 338:      */
>> 339:     private static String dumpHexBytes(byte[] data, int dataLen,
>> 340:             int itemsPerLine, String lineDelim, String itemDelim) {
> 
> You always call with `dataLen = data.length`. Is it still necessary to add this argument?

Yes, I would prefer to keep this.  I made the change in order to help me debug draining the input stream and I felt it prudent to leave it in place, along with the main test's debug flag just in case.

-------------

PR: https://git.openjdk.org/jdk/pull/12370


More information about the security-dev mailing list