RFR: 8297878: KEM: Implementation [v15]

Sibabrata Sahoo ssahoo at openjdk.org
Fri May 12 10:29:58 UTC 2023


On Thu, 11 May 2023 20:56:54 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> The KEM API and DHKEM impl. Note that this PR uses new methods in https://github.com/openjdk/jdk/pull/13250.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   deterministic randomness

test/jdk/com/sun/crypto/provider/DHKEM/Compliance.java line 205:

> 203:         byte[] enc1 = e.encapsulate().encapsulation();
> 204:         byte[] enc2 = e.encapsulate().encapsulation();
> 205:         Asserts.assertFalse(Arrays.equals(enc1, enc2));

Another case,
KEM kem = KEM.getInstance("DHKEM");
   KEM.Encapsulator e1 = kem.newEncapsulator(pk, random);
KEM kem1 = KEM.getInstance("DHKEM");
   KEM.Encapsulator e2 = kem1.newEncapsulator(pk, random);
byte[] enc1 = e1.encapsulate().encapsulation();
byte[] enc2 = e2.encapsulate().encapsulation();
Asserts.assertFalse(Arrays.equals(enc1, enc2));

Can this case be added too?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1192194605



More information about the security-dev mailing list