RFR: 8297878: KEM: Implementation [v15]

Anthony Scarpino ascarpino at openjdk.org
Mon May 15 19:10:59 UTC 2023


On Thu, 11 May 2023 20:56:54 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> The KEM API and DHKEM impl. Note that this PR uses new methods in https://github.com/openjdk/jdk/pull/13250.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   deterministic randomness

src/java.base/share/classes/javax/crypto/KEM.java line 217:

> 215:          * <p>
> 216:          * An implementation may choose to not support arbitrary combinations
> 217:          * of {@code from}, {@code to}, and {@code algorithm}.

As previously discussed, I think having a code example of the `from` and `to` would be good idea.  That way it's very clear going from 0 to 32 is 32 bytes and not 33.  And an example would be a good idea in the SPI.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1194258367


More information about the security-dev mailing list