RFR: 8297878: KEM: Implementation [v15]

Weijun Wang weijun at openjdk.org
Tue May 16 16:28:30 UTC 2023


On Mon, 15 May 2023 19:07:59 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   deterministic randomness
>
> src/java.base/share/classes/javax/crypto/KEM.java line 217:
> 
>> 215:          * <p>
>> 216:          * An implementation may choose to not support arbitrary combinations
>> 217:          * of {@code from}, {@code to}, and {@code algorithm}.
> 
> As previously discussed, I think having a code example of the `from` and `to` would be good idea.  That way it's very clear going from 0 to 32 is 32 bytes and not 33.  And an example would be a good idea in the SPI.

Added some comments and example lines. And I found A REAL BUG in `DHKEM`!!! Having two styles of slicing an array is indeed a problem.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1195412465



More information about the security-dev mailing list