RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]

Bradford Wetmore wetmore at openjdk.org
Thu May 18 21:56:54 UTC 2023


On Thu, 18 May 2023 17:49:07 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985)
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
> 
>   all review comments applied

src/java.base/share/classes/sun/security/ssl/CertificateRequest.java line 385:

> 383:             X509ExtendedKeyManager km = chc.sslContext.getX509KeyManager();
> 384:             String clientAlias = null;
> 385: 

Many of these lines are > 80 chars, which makes side-by-side challenging.  Please keep line changes to a max of 80 chars.

Didn't check the other file, but think I saw similar things there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1198340417



More information about the security-dev mailing list